Better domain errors, atmosphere density in ID, and velocity limiting in atmosphere. #6429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Turn some ASSERTs into ERRORs because these can be triggered from the input file! - Clarify an error message about the cube with values. Not having values in an error makes it more difficult to fix.
This allows us to start the code in a more consistent state since atmosphere treatments are generally applied _after_ a time step.
nilsdeppe
force-pushed
the
bns_improvements_5
branch
from
a0cba85 to
fa59dee
Compare
kidder
requested changes
Jan 14, 2025
| r_squared_(momentum_density_squared / | ||
| square(rest_mass_density_times_lorentz_factor)), | ||
| r_(std::sqrt(r_squared_)), | ||
| r_(std::sqrt(momentum_density_squared / |
There was a problem hiding this comment.
I agree, it shouldn't be needed, but might help with robustness against negative evolved vars, so I would prefer to keep it to match the previous algorithm...
| ASSERT(orientations_of_all_blocks.size() == corners_of_all_blocks.size(), | ||
| "Each block must have an OrientationMap relative to an edifice."); | ||
| if (orientations_of_all_blocks.size() != corners_of_all_blocks.size()) { | ||
| ERROR("Each block must have an OrientationMap relative to an edifice."); |
There was a problem hiding this comment.
I have no idea, sorry. You'll have to ask the original author, which looks like is Marcie based on the git log.
kidder
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Various changes that make BNS simulations more robust. More will be added in future PRs as I write tests for the code.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments